Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the tag's parent frame to the camera optical frame #101

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

christian-rauch
Copy link
Contributor

From the commit message:

The image header carries the 'frame_id' which is set by a camera driver to
the optical image frame. The pose of tags that are detected in an image are
therefore defined in this optical frame.

This makes the launchfile argument and node parameter camera_frame obsolete.

Fixes #100 .

The image header carries the 'frame_id' which is set by a camera driver to
the optical image frame. The pose of tags that are detected in an image are
therefore defined in this optical frame.
@christian-rauch
Copy link
Contributor Author

Is this ready for merging?

@wxmerkt
Copy link
Collaborator

wxmerkt commented Jul 7, 2021

Yes, it should be - I was waiting to see if someone comments about the removal of camera_frame resulting in an issue for existing users. I don't expect it to be since it should merely simplify usage (the driver should fill this in correctly).

@wxmerkt wxmerkt merged commit c2d7e27 into AprilRobotics:master Aug 17, 2021
@christian-rauch christian-rauch deleted the frame_from_image branch August 17, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extract optical frame from image header
2 participants