Widespread minor string.split() handling #914
marcustyphoon
started this conversation in
Tech Office
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In a whole bunch of random places, we call the
split
method on a string and don't use.filter(Boolean)
on the result, leading to possible unintended empty-string array entries if the input string is empty or has sequential commas or spaced commas.I don't see anywhere where this can cause buggy behavior, and PRing it would be a lot for something harmless and would probably merge conflict eventually.
Beta Was this translation helpful? Give feedback.
All reactions