Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize text preference processing across scripts #1188

Open
marcustyphoon opened this issue Aug 11, 2023 · 2 comments
Open

Standardize text preference processing across scripts #1188

marcustyphoon opened this issue Aug 11, 2023 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@marcustyphoon
Copy link
Collaborator

Concept

As pointed out in discussion in #1185, CleanFeed's blog preference breaks if you write them as uppercase. This is also true for Hide Avatars, Show Originals, and Themed Posts. Painter's tag input does not suffer from case sensitivity and also strips hashtag characters (i.e. #982). Quick Reblog and Tag Replacer are probably inconsistent as well.

Doing a pass over all of these is probably a good idea. (Should tags, in general, be case sensitive? When using them as a match filter I assume the answer is no—Tumblr treats them as the same—but when adding tags to a post, case is preserved, so one has to be careful with that too.)

@marcustyphoon marcustyphoon added enhancement New feature or request help wanted Extra attention is needed labels Aug 11, 2023
@enchanted-sword
Copy link
Contributor

The safest practice would probably be to convert both the preference value and the post's tags to lowercase.

@enchanted-sword
Copy link
Contributor

Quick reblog and tag replacer already seem to strip hashtags and ignore case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants