Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Recommended not hiding recommended tags #1335

Closed
krookodilehunter opened this issue Nov 30, 2023 · 9 comments · Fixed by #1341
Closed

No Recommended not hiding recommended tags #1335

krookodilehunter opened this issue Nov 30, 2023 · 9 comments · Fixed by #1341
Labels
bug Something isn't working

Comments

@krookodilehunter
Copy link

Platform

Windows 10

Browser

Brave 1.60.125

Addon version

v0.23.1

Details

despite having the recommended tags option selected, i am still seeing recommended tags. reloading the page sometimes works but it doesn't all the time. i've also noticed that when the recommended tags are on my dashboard, some posts are blocked from showing up, but are able to be seen if the recommended tags block is gone.

image

@krookodilehunter krookodilehunter added the bug Something isn't working label Nov 30, 2023
@luxidoptera
Copy link

Corroborating. This is happening to me too.
image

Also extends to other between-post recommendation windows.
image

@AprilSylph AprilSylph added the help wanted Extra attention is needed label Nov 30, 2023
@Avakining
Copy link

Corroborating as well. Recommended blogs are also appearing.
Screenshot 2023-11-30 at 17 55 30
XKit Rewritten 0.23.1
Firefox 120.0.1
macOS 14.1.2

@inklesspen
Copy link
Contributor

The CSS has changed for blog carousels. It used to use blogCarousel, but now uses carouselWrapper.

@taracdia
Copy link

taracdia commented Dec 2, 2023

This is also occurring in Firefox nightly (Android Mobile)

@marcustyphoon
Copy link
Collaborator

You can assign multiple people to each issue or pull request, including yourself, anyone who has commented on the issue or pull request, anyone with write permissions to the repository, and organization members with read permissions to the repository.
– https://docs.github.com/en/issues/tracking-your-work-with-issues/assigning-issues-and-pull-requests-to-other-github-users

Apparently I can't assign this issue even if a PR is set to close it! Thanks GitHub.

@marcustyphoon marcustyphoon removed the help wanted Extra attention is needed label Dec 2, 2023
@marcustyphoon marcustyphoon pinned this issue Dec 2, 2023
@arcanetrivia
Copy link

I suppose this "Top X blogs" carousel in the middle of a tag page is the same idea?
image

@marcustyphoon marcustyphoon unpinned this issue Dec 7, 2023
@vivacious-cat
Copy link

Hi there, just wanting to check if this has been repaired? Current user, and having same issue on Firefox in June 2024...
reccomended blogs still showing

@marcustyphoon
Copy link
Collaborator

I haven't checked the code to be sure, but this should probably be fixed in version 1.0.0, which we've submitted to Mozilla for review! It usually takes a few days.

@marcustyphoon
Copy link
Collaborator

@vivacious-cat This should be fixed in v1.0.0, which is now out for all platforms; if you update and close+reopen your Tumblr tab and it's still not fixed, please file a new issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants