Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Reblog not highlighting all reblogged posts #95

Closed
asshuka opened this issue Mar 14, 2021 · 4 comments
Closed

Quick Reblog not highlighting all reblogged posts #95

asshuka opened this issue Mar 14, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@asshuka
Copy link

asshuka commented Mar 14, 2021

  • The browser I'm using is: Firefox
  • My browser version is: 86.0.1
  • My XKit Rewritten version is: 0.2.1

Quick Reblog does highlight the reblog button right after reblogging, but when you refresh or navigate away from the page, it goes back to the default color. Curiously, the first reblogged post of the page is properly highlighted. I've tested across different Tumblr palettes, as well with Palettes for Tumblr disabled.

@asshuka asshuka added the bug Something isn't working label Mar 14, 2021
@AprilSylph
Copy link
Owner

unable to reproduce on Firefox 86.0.1 (64-bit). could you upload your configuration (from the Backup tab) here for further testing? GitHub should allow you to attach the .json file

@asshuka
Copy link
Author

asshuka commented Mar 15, 2021

Unfortunately it doesn't! I just renamed the file to stick a .txt on it, hopefully file is still usable after re-renaming 🙇‍♀️
XKit Payload 1615762347022.json.txt

@AprilSylph

This comment has been minimized.

@AprilSylph
Copy link
Owner

nevermind, i think i've just been able to reproduce this; my guess is that loading new posts while reblogging a post can cause data to be overwritten. i'll need to rethink how quick_reblog.alreadyRebloggedList is handled in order to make it more reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants