[BE] allow deleting multiple coupons

aa_stripe/admin.py

@@ -63,10 +63,6 @@ def get_readonly_fields(self, request, obj=None):
 
         return self.readonly_fields
 
-    def has_delete_permission(self, request, obj=None):
-        # allow deleting single object, but disable bulk delete (bulk delete does not call models' .delete() method)
-        return bool(obj)
-
 
 class StripeSubscriptionAdmin(ReadOnly):
     list_display = (

aa_stripe/models.py

@@ -64,6 +64,20 @@ class Meta:
         ordering = ["id"]
 
 
+class StripeCouponQuerySet(models.query.QuerySet):
+    def delete(self):
+        # StripeCoupon.delete must be executed (along with post_save)
+        for obj in self:
+            obj.delete()
+
+        return 0, {self.model._meta.label: 0}
+
+
+class StripeCouponManager(models.Manager):
+    def get_queryset(self):
+        return StripeCouponQuerySet(self.model, using=self._db)
+
+
 class StripeCoupon(StripeBasicModel):
     # fields that are fetched from Stripe API
     STRIPE_FIELDS = {
@@ -140,6 +154,8 @@ class StripeCoupon(StripeBasicModel):
     is_deleted = models.BooleanField(default=False)
     is_created_at_stripe = models.BooleanField(default=False)
 
+    objects = StripeCouponManager()
+
     def __init__(self, *args, **kwargs):
         super(StripeCoupon, self).__init__(*args, **kwargs)
         self._previous_is_deleted = self.is_deleted

tests/test_coupons.py

@@ -1,6 +1,7 @@
 import time
 from datetime import datetime
 
+import mock
 import requests_mock
 import simplejson as json
 from django.contrib.auth import get_user_model
@@ -122,6 +123,14 @@ def test_delete(self):
             coupon.refresh_from_db()
             self.assertTrue(coupon.is_deleted)
 
+        with mock.patch("aa_stripe.models.StripeCoupon.delete") as mocked_delete:
+            # also test the overriden queryset's delete
+            coupon2 = self._create_coupon(coupon_id="CPON2")
+            coupon3 = self._create_coupon(coupon_id="CPON3")
+            result = StripeCoupon.objects.filter(pk__in=[coupon2.pk, coupon3.pk]).delete()
+            self.assertEqual(mocked_delete.call_count, 2)
+            self.assertEqual(result, (0, {"aa_stripe.StripeCoupon": 0}))
+
     def test_admin_form(self):
         # test correct creation
         data = {