Sync cards via webhook #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkrzyzaniak
requested changes
Jan 6, 2018
aa_stripe/models.py
Outdated
| else: | ||
| raise StripeWebhookParseError(_("Card with this id does not exists at Stripe API")) | ||
| else: | ||
| raise StripeWebhookParseError(_("Card with this id and customer already exists")) |
There was a problem hiding this comment.
we'll have this error each time a new card gets created
aa_stripe/models.py
Outdated
| @@ -583,6 +594,35 @@ def _parse_coupon_notification(self, action): | |||
| elif action == "deleted": | |||
| StripeCoupon.objects.filter(coupon_id=coupon_id, created=created).delete() | |||
|
|
|||
| def _parse_customer_source_notification(self, action): | |||
| stripe_card_id = self.raw_data["data"]["object"]["id"] | |||
There was a problem hiding this comment.
if type != card:
return
pkrzyzaniak
requested changes
Jan 6, 2018
aa_stripe/models.py
Outdated
| elif action == "updated": | ||
| try: | ||
| card = StripeCard.objects.get(stripe_card_id=stripe_card_id, customer=customer) | ||
| for updated_field in StripeCard.STRIPE_UPDATABLE_FIELDS & set( |
There was a problem hiding this comment.
Comment above deleted - it was invalid. Anyway, it would be best to just call here "retrieve from stripe" & update the card based on the newest data.
remik
requested changes
Jan 8, 2018
aa_stripe/models.py
Outdated
| @@ -125,6 +126,16 @@ def create_at_stripe(self): | |||
| self.save() | |||
| return self | |||
|
|
|||
| def sync_with_stripe(self): | |||
There was a problem hiding this comment.
Rename to refresh_from_stripe in other places.
aa_stripe/models.py
Outdated
| except StripeCustomer.DoesNotExist: | ||
| raise StripeWebhookParseError( | ||
| _("There is no customer with id that is assigned to this card in our database")) | ||
| if action == "created": |
There was a problem hiding this comment.
Line break before it for better readable.
hash
force-pushed
the
feature/sync-cards-via-webhook
branch
from
e751c25
to
f59c7a2
Compare
remik
approved these changes
Jan 8, 2018
pkrzyzaniak
approved these changes
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.