APDS-85 - [BE] move permanent token authentication to a separate library #1
Conversation
|
Changes Unknown when pulling 091143f on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling f5d3231 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling b0a4c73 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling b0a4c73 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling 59da092 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling e259db6 on feature/APDS-85 into ** on master**. |
5 similar comments
|
Changes Unknown when pulling e259db6 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling e259db6 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling e259db6 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling e259db6 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling e259db6 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling 298ad91 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling 298ad91 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling 3d19d8f on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling 3d19d8f on feature/APDS-85 into ** on master**. |
Things that came out during implementing the library in demo api
|
Changes Unknown when pulling f086e21 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling bd58aa5 on feature/APDS-85 into ** on master**. |
| @@ -0,0 +1,2 @@ | |||
| # Change Log | |||
| All notable changes to this project will be documented in this file. | |||
There was a problem hiding this comment.
Okay, I will change it to 1.0.0 (as we talked about it, we will use semver).
|
Changes Unknown when pulling 1e88eb7 on feature/APDS-85 into ** on master**. |
There was a problem hiding this comment.
Two things for the future:
- there should be a way to see all logged in devices (as in google for example): so you can see which devices are authorized
- there should be a way to logout all devices / single device, not necessarily the one user is operating at the moment.
| { | ||
| "token": "ads344fdgfd5454yJ0eAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VynRlYW1AYXJhYmVsLmxh", | ||
| "permanent_token": "gfd5454yJ0eAiOiJKV1QiLCJhbGciOiJ", | ||
| "device_id": 1 |
There was a problem hiding this comment.
why the need for device_id? permanent_token would not be enough?
There was a problem hiding this comment.
This was agreed with @jacoor in the previous pull requests (in https://github.com/ArabellaTech/django-rest-framework-jwt), permanent_token is too fragile.
README.rst
Outdated
| ``REST_FRAMEWORK`` configuration in **settings.py** | ||
|
|
||
|
|
||
| **PermitHeaders middleware** |
There was a problem hiding this comment.
PermittedHeaders would be a better name I think
There was a problem hiding this comment.
Hmm, why not, will change.
|
@pkrzyzaniak Both of those things are implemented. You can list all user's devices (DeviceViewSet), and user can logout each device they are logged in. |
|
Changes Unknown when pulling 10f1647 on feature/APDS-85 into ** on master**. |
7 similar comments
|
Changes Unknown when pulling 10f1647 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling 10f1647 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling 10f1647 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling 10f1647 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling 10f1647 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling 10f1647 on feature/APDS-85 into ** on master**. |
|
Changes Unknown when pulling 10f1647 on feature/APDS-85 into ** on master**. |
No description provided.