Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idna-uts46 crashes for some emojis #25

Open
mdtanrikulu opened this issue Jul 14, 2021 · 1 comment 路 May be fixed by #26
Open

idna-uts46 crashes for some emojis #25

mdtanrikulu opened this issue Jul 14, 2021 · 1 comment 路 May be fixed by #26

Comments

@mdtanrikulu
Copy link
Contributor

mdtanrikulu commented Jul 14, 2021 •
edited
Loading

Current version of idna-uts46 raises an error for some of the emojis, like this one -> 馃. I haven't really checked exactly on which version this issue has been fixed, but I can tell that on the latest one this one works as expected.

This is the part of the code causing the issue in current version.

uts46.toUnicode(name, {useStd3ASCII: true, transitional: false})

Mentioned here: ensdomains/ens-app#1167
@mdtanrikulu mdtanrikulu linked a pull request Aug 7, 2021 that will close this issue
Open
@the-emerald the-emerald mentioned this issue Aug 9, 2021
Closed
@NickKelly1
Copy link

same issue here

this error is occurring frequently

octal-crypto added a commit to octal-crypto/crypto-duckies that referenced this issue Nov 8, 2022
@octal-crypto
fix emoji ENS bug Arachnid/eth-ens-namehash#25
69d324d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump idna-uts46-tx to 3.4.x mdtanrikulu/eth-ens-namehash
2 participants
@mdtanrikulu @NickKelly1