Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE-566] geo_s2 analyzer test case #263

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Conversation

aMahanna
Copy link
Member

DE-566 seeks to introduce geo_s2 analyzer creation support.

Given that the database.create_analyzer method accepts analyzer_type as a parameter, there is no feature implementation required.

Nevertheless a test case has been added to ensure python-arango's support for geo_s2 analyzer creation (on EE >=3.10.5 only)

@aMahanna aMahanna requested a review from dothebart July 28, 2023 19:20
Copy link
Collaborator

@alexbakharew alexbakharew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check all analyzer parameters

tests/test_analyzer.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Merging #263 (9e00d20) into main (8b09e07) will increase coverage by 0.42%.
Report is 9 commits behind head on main.
The diff coverage is 93.75%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
+ Coverage   98.58%   99.01%   +0.42%     
==========================================
  Files          26       26              
  Lines        3899     3953      +54     
==========================================
+ Hits         3844     3914      +70     
+ Misses         55       39      -16     
Files Changed Coverage Δ
arango/collection.py 98.50% <50.00%> (+2.03%) ⬆️
arango/client.py 98.30% <75.00%> (-1.70%) ⬇️
arango/aql.py 95.04% <100.00%> (+0.04%) ⬆️
arango/cursor.py 100.00% <100.00%> (ø)
arango/http.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@alexbakharew alexbakharew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aMahanna aMahanna merged commit 74680ae into main Jul 31, 2023
6 checks passed
@aMahanna aMahanna deleted the feature/de-566-geo-s2-analyzer branch July 31, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants