Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: raise_on_document_error param for collection.update_many #273

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented Aug 16, 2023

New raise_on_document_error parameter for update_many:

:param raise_on_document_error: Whether to raise if a DocumentRevisionError
            or a DocumentUpdateError is encountered on an individual document,
            as opposed to returning the error as an object in the result list.
            Defaults to False.
col.update_many(docs, raise_on_document_error=True)

@aMahanna aMahanna self-assigned this Aug 16, 2023
@aMahanna aMahanna marked this pull request as draft August 16, 2023 14:57
@aMahanna aMahanna marked this pull request as ready for review August 16, 2023 14:57
@codecov-commenter
Copy link

Codecov Report

Merging #273 (1942ba2) into main (744a6e9) will increase coverage by 0.00%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          26       26           
  Lines        3958     3960    +2     
=======================================
+ Hits         3919     3921    +2     
  Misses         39       39           
Files Changed Coverage Δ
arango/client.py 98.41% <ø> (ø)
arango/http.py 100.00% <ø> (ø)
arango/collection.py 98.51% <100.00%> (+<0.01%) ⬆️

Copy link
Contributor

@geenen124 geenen124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arango/collection.py Show resolved Hide resolved
@aMahanna aMahanna merged commit f5b1d50 into main Aug 16, 2023
6 checks passed
@aMahanna aMahanna deleted the update-many-raise-on-doc-error branch August 16, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants