Implement re.replace(string, Regex, proc(...)) , simplify implmentation #1855
Conversation
|
flaviut: Your re.replace(string, Regex, proc(...)) is fine but simplify the implemenation by using a private template please to avoid performance regressions and to avoid some artefacts that effect analysis might produce (it shouldn't but maybe I overlooked something). |
|
I've improved performance, but it's still not quite as good as before. I'm not really sure why. IMO it's close enough, please give more feedback. |
|
Well how much slower is it? 1% ? |
The other replace methods can be cleaned up to be in terms of this
Use the recently-created implementation using a lambda
Instead of passing the full matches array to the arguments of the proc, it passes only the matches that are possible
replacef tends to mean that it receives that captures
new: 11.95 old: 8.47 new template: 9.33
|
old: 8.47 In percents, that's ~10% slower on a micro-benchmark. Not nearly as trivial as you hoped unfortunately. My profiler is having trouble understanding the code, so I've run into a wall optimizing. I've lost the code to that benchmark, but import re
const data = slurp("./rand") # 1K file of random bytes
let pattern = re"\d"
var optbuster = 0
for i in 1 .. 100000:
optbuster += data.replacef(pattern, "asdasd")[5].int
echo optbusterarrives at similar results |
|
Do it properly then please. |
Exactly what it says on the tin.
I'd like to sneak 1bfc93c in, but the real meat is in 0aba0f5.