Introduce pedantic mode for tester #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| backend.close() | ||
| if optPedantic: | ||
| var failed = r.total - r.passed - r.skipped | ||
| if failed > 0 : quit(failed) |
There was a problem hiding this comment.
it could be simplified (although less readable)
if optPedantic:
quit(r.total - r.passed - r.skipped)I can do it if you like
There was a problem hiding this comment.
No need for the "simplified" version, but use 'let' instead of 'var'.
Motivation
----------
External tools need to know whether or not any test in suite failed. For
example buildbot, or packaging tool would like to stop the execution and
mark it as failed if some tests does not pass.
Modification
------------
Add `--pedantic` switch to tester program which will force it to quit
with non-zero exit code if at least one failure detected. Also update
`tests()` proc in koch to inspect result from tester and propagate it to
user.
Result
------
Nothing has changed in default behaviour. But following invocations will
exit with non-zero code if there failed tests:
./koch tests --pedantic all
./tests/testament/tester --pedantic all
Araq
added a commit
that referenced
this pull request
May 25, 2015
Introduce pedantic mode for tester
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
External tools need to know whether or not any test in suite failed. For
example buildbot, or packaging tool would like to stop the execution and
mark it as failed if some tests does not pass.
Modification
Add
--pedanticswitch to tester program which will force it to quitwith non-zero exit code if at least one failure detected. Also update
tests()proc in koch to inspect result from tester and propagate it touser.
Result
Nothing has changed in default behaviour. But following invocations will
exit with non-zero code if there failed tests:
Fixes #2793