Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idetools --suggest provides incorrect answers #484

Closed
gradha opened this issue Jun 14, 2013 · 1 comment
Closed

Idetools --suggest provides incorrect answers #484

gradha opened this issue Jun 14, 2013 · 1 comment
Labels

Comments

@gradha
Copy link
Contributor

gradha commented Jun 14, 2013

When using the --suggest idetools switch, the answers should be context sensitive, but they aren't. When you use the dot syntax to write variable.foo and query completions for foo* procs, idetools answers with procs matching the beginning prefix which don't have as first parameter the parameter type of the variable preceeding the proc, or even procs which don't accept parameters at all, which is absolutely wrong.

Maybe it is impossible for idetools to know that the dot syntax is being used and it considers the prefix alone without the variable type info?

Araq added a commit that referenced this issue Jul 2, 2013
Adds idetools --suggest test case. Refs #484.
reactormonk pushed a commit to reactormonk/nim that referenced this issue Apr 7, 2014
1) There are too many suggestions for the given prefix.
2) The suggestions don't take into account the preceeding type.
3) trackDirty only works on caas mode.
reactormonk pushed a commit to reactormonk/nim that referenced this issue Apr 7, 2014
@Araq Araq added the tools label Jul 1, 2014
@Araq
Copy link
Member

Araq commented Jan 17, 2016

nimsuggest has its own bug tracker now.

@Araq Araq closed this as completed Jan 17, 2016
Clyybber pushed a commit to Clyybber/Nim that referenced this issue Sep 16, 2023
484: Internal remove VM legacy reports r=saem a=saem

## Summary

This is the first part of removing legacy reports from the VM code base.
It does so by introducing VM and VM Code Generation Events, that are
used in lieu of 'reports'. This is just the start and much more work is
required prior to completion.

## Details

- Added `VmEvent` and `VmGenDiag` types to capture data, these are
  similar to but `VMReports` cruft, but are owned and defined by the VM
  in `vmdef`
- Source code location tracking (`TLineInfo`) is now minimized and much
  of this has been moved to the caller (`compilerbridge`, `vmrunner`,
  etc)
- Introduced `VmExecTrace` to handle code listing output, the type is
  at the very last more lightweight
- `TCtx` has a `vmExecTracer` callback to handle exec trace output
- use tracer callback in `compilerbridge`, `nimeval`, & `scriptconfig`
- Dropped `VMReport` and `DebugReport` dependencies from `vm`

### Compiler/Runner Bridging

- Introduced a somewhat simpler `VmStackTrace` and migrated
  `ExecErrorReport` to use that
- removed `opcNError`, `opcNWarning`, and `opcNHint`, these are now
  callbacks

### Miscellaneous

- Removed a number of unused import warnings
- Now fewer dependencies on `TCtx.debug`, hopefully easier to remove
- Fixed lots of code formatting issues

### Future Work


- Obviously get rid of the remaining reports cruft
- Sem/Ast reports clean-up, one reason why this clean-up can't done in
  one shot
- Events ease dropping the `TCtx.debug` dependency, finish this
- Slim down `VmGenDiag` data
- `YieldReason`/syscall interface to break remaining reports
  dependencies after Sem/Ast



Co-authored-by: Saem Ghani <saemghani+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants