Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys:
I've been building the project using gradle in the command line, and I've noticed that some files in the project have your local configuration. I think those files shouldn't be included in order to allow any dev to build the project.
I also found a bad dependency reference in android-dsl/build.gradle. That project is pointing at :androidapp:SwissKnife instead of just :SwissKnife . I've changed it and now dependency is resolved as expected.
Next I removed the .gradle/ dir. Unless you tell me otherwise I think it makes no sense to keep that directory.
Last I would like to ask you something. Have you ever come across a classnotfoundexception during gradle build because it didn't find the class android/support/v4/widget/DrawerLayoutImpl
After all changes I had an error. It has to do with the fact that when executing gradle build after removing all build/ directories. Once I had that error next time I built the project I never had that problem again.
In case you face same error (maybe when deploying on Travis) the following command line worked for me:
gradle generateDebugSources && gradle build
Anyway I've raised an issue in the groovy-gradle plugin in case Cedric Champeau can give me a tip about this problem (groovy/groovy-android-gradle-plugin#31).
I keep looking the new features, and are really great, domain classes 'ala' Grails, form handling/validation to say a few, I really like it, good work.