Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android dsl #7

Merged
merged 4 commits into from Dec 16, 2014
Merged

Android dsl #7

merged 4 commits into from Dec 16, 2014

Conversation

mariogarcia
Copy link
Collaborator

Hi guys:

I've been building the project using gradle in the command line, and I've noticed that some files in the project have your local configuration. I think those files shouldn't be included in order to allow any dev to build the project.

I also found a bad dependency reference in android-dsl/build.gradle. That project is pointing at :androidapp:SwissKnife instead of just :SwissKnife . I've changed it and now dependency is resolved as expected.


 - compile project(':androidapp:SwissKnife')
 + compile project(':SwissKnife')

Next I removed the .gradle/ dir. Unless you tell me otherwise I think it makes no sense to keep that directory.

Last I would like to ask you something. Have you ever come across a classnotfoundexception during gradle build because it didn't find the class android/support/v4/widget/DrawerLayoutImpl

After all changes I had an error. It has to do with the fact that when executing gradle build after removing all build/ directories. Once I had that error next time I built the project I never had that problem again.

In case you face same error (maybe when deploying on Travis) the following command line worked for me:

gradle generateDebugSources && gradle build

Anyway I've raised an issue in the groovy-gradle plugin in case Cedric Champeau can give me a tip about this problem (groovy/groovy-android-gradle-plugin#31).

I keep looking the new features, and are really great, domain classes 'ala' Grails, form handling/validation to say a few, I really like it, good work.

@jmartinesp
Copy link
Owner

I think the ClassNotFoundException comes from IDEA not including the support library. Are you manually building or using IDEA? If using IDEA, how are your Run configurations, using "Make" or "gradle build"?

Anyways, thanks for the PR, I also think that those files should be generated and not on the git repo.

@mariogarcia
Copy link
Collaborator Author

I'm building manually. In fact when using Intellij, the problem vanishes, mainly because it executes some gradle tasks before actually building the project (generateDebugSources for instance). I think it could be a problem only when using CI like Travis/Jenkins or like me building SwissKnife + android-dsl from the console, and it that moment at least we have the workaround I mentioned.

@jmartinesp
Copy link
Owner

Ok. I'm merging this 👍

jmartinesp added a commit that referenced this pull request Dec 16, 2014
Tidy up some configuration files so we don't have to manually fix them before import.
@jmartinesp jmartinesp merged commit 5359621 into jmartinesp:android-dsl Dec 16, 2014
@mariogarcia
Copy link
Collaborator Author

Great thanks!!!

@eugene-kamenev
Copy link
Collaborator

Mario,

Some errors was because of me, I am using android-dsl branch with separate
project to create spring rest service along with android app, It is needed
to complete my @RestableEntity idea. Sorry for that and thanks for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants