df/FloorFilter_IV #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using Button consistently across the level and facility picker we get consistent style by using a common modifier Update SiteAndFacilitySelector.swift Update SiteAndFacilitySelector.swift Create Button.swift
Update SiteAndFacilitySelector.swift Update SiteAndFacilitySelector.swift
This reverts commit 5e3f250.
zkline101
previously approved these changes
Jun 20, 2022
zkline101
previously approved these changes
Jun 21, 2022
mhdostal
requested changes
Jun 22, 2022
Sources/ArcGISToolkit/Components/FloorFilter/SiteAndFacilitySelector.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/FloorFilter/SiteAndFacilitySelector.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/FloorFilter/SiteAndFacilitySelector.swift
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/FloorFilter/SiteAndFacilitySelector.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Mark Dostal <mdostal@esri.com>
Co-authored-by: Mark Dostal <mdostal@esri.com>
Co-authored-by: Mark Dostal <mdostal@esri.com>
…runtime-toolkit-swift into df/FloorFilter_IV
mhdostal
approved these changes
Jun 28, 2022
zkline101
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Looks good. Only one thing I noticed is when I first opened up the example, the site sheet appeared and said "No matches found" then the text quickly went away because the sites were loaded. Maybe that could be improved to let the user know the sites are loading.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40
This PR iterates on FloorFilter_III with 3 main changes:
.searchable.Floor Filter 3
Floor Filter 4
