Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Electric Engine is green tech but depends on Advanced oil processing, which is blue tech #421

Closed
adoa opened this issue Oct 27, 2020 · 7 comments
Labels
Angels Petrochem petrochem related Impact: Bug Something could be wrong

Comments

@adoa
Copy link
Contributor

adoa commented Oct 27, 2020

State of the vanilla tech tree in 1.0.0: Electric engine is blue tech, depends on blue tech, and is required for blue tech
electric_engine_vanilla

State of the Angel's tech tree (Industry overhaul enabled, but otherwise default settings):
Electric engine is green tech, depends on green & blue tech, and is required for blue tech
electric_engine_angels

This feels very inconsistent. In Angel's Petrochem, lubricant can be made before having blue tech. This makes the dependence on Advanced oil processing feel out of place. In vanilla, on the other hand, lubricant can only be made from Advanced oil processing (or later via Coal liquefaction).

Angel's Petrochem should make Electric engines themselves proper blue tech as they are in vanilla, or remove the dependence on Advanced oil processing.

I highly advocate making electric engines genuine blue tech to stay consistent with vanilla. This change would emphasize the role of Angel's Crawler robots from Angel's Industries.

[edit]
I also had a brief look at the positioning of the corresponing tech in the tech overhaul. I am not sure I understand the logic behind the tech overhaul, but Mechanical parts 4 looked fishy: depending on blue datacore tech, required for orange datacore tech, but being itself grey datacore tech? This could be either intentional or the result of the tech overhaul's version of this inconsistency. The devs should look at that case, too.
[/edit]

Additional information:
This was reported previously
https://forums.factorio.com/viewtopic.php?f=185&t=89765
https://discord.com/channels/164794742893182976/693538202153123930/770732569507397680

@LovelySanta
Copy link
Collaborator

Can you upload a save file so I can sync to your mods and settings? With overhaul enabled, it is blue science for me... It could be that it is fixed already.
image

@adoa
Copy link
Contributor Author

adoa commented Oct 29, 2020

Turns out I was a bit too quick in judging the culprit. The mod that removes the blue science packs from lubricant and electric engine is Bob's MCI. Angel's Petrochem adds the dependence on Advanced oil processing.

Individually, they do things that are fine. But together they mess things up.

I attached a save with a minimal mod setup to reproduce my observation:

  • Angel's Petrochem (+Angel's Refining)
  • Bob's MCI (+Bob's Library)
  • All settings default

electric_engine_inconsistency.zip

@adoa
Copy link
Contributor Author

adoa commented Oct 29, 2020

Coming to think about it: Why exactly should Electric engine depend on Advanced oil processing in the first place?

@LovelySanta
Copy link
Collaborator

LovelySanta commented Oct 29, 2020

Turns out I was a bit too quick in judging the culprit. The mod that removes the blue science packs from lubricant and electric engine is Bob's MCI. Angel's Petrochem adds the dependence on Advanced oil processing.

This is not an angel mod issue then. I'll mark it as mod incompatibility as it is madclowns mod that is breaking it. Assigning @Pezzawinkle to look into that.

Coming to think about it: Why exactly should Electric engine depend on Advanced oil processing in the first place?

It is a base game thing, where lubricant is from heavy oil, which comes from advanced oil processing, and thus being blue science. We might change that in angels mod, however since the motors are blue science, we kept them at blue science and prerequisited on a blue chemical process.

@LovelySanta LovelySanta added the Impact: Mod compatibility Mainly involves 3rd party mods label Oct 29, 2020
@adoa
Copy link
Contributor Author

adoa commented Oct 29, 2020

This is not an angel mod issue then. I'll mark it as mod incompatibility as it is madclowns mod that is breaking it. Assigning @Pezzawinkle to look into that.

Why do you say Madclown? I said "Bob's Metals, Chemicals and Intermediates", not Madclown. Since it is an incompatibility with one of Bob's mods, I would argue that it is a genuine issue for Angel's mods to take care of.

@LovelySanta LovelySanta added Angels Petrochem petrochem related Impact: Bug Something could be wrong and removed Impact: Mod compatibility Mainly involves 3rd party mods labels Oct 29, 2020
@LovelySanta
Copy link
Collaborator

woops, I've just read MCl and thought of MadClown, i've corrected it.

@LovelySanta
Copy link
Collaborator

Fixed in 2b30fed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Angels Petrochem petrochem related Impact: Bug Something could be wrong
Projects
None yet
Development

No branches or pull requests

3 participants