Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log WebSocketSharp errors to somewhere... else... #72

Open
Ijwu opened this issue Sep 10, 2022 · 0 comments
Open

Log WebSocketSharp errors to somewhere... else... #72

Ijwu opened this issue Sep 10, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@Ijwu
Copy link
Contributor

Ijwu commented Sep 10, 2022

I believe we can set up custom loggers in WebSocketSharp's WebSocket object. We should have it log somewhere other than stderr or wherever it currently goes since in Unity games that almost always ends up in the Unity player logs which is disparate from where other errors typically go (such as stdout, modloader logs, etc.).

We can possibly provide options to allow callers to provide their own loggers and then provide another NuGet package with logger implementations for things like BepInEx or Hollow Knight's ModdingApi, as examples.

@Ijwu Ijwu added the enhancement New feature or request label Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant