Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Remove CDN #644

Closed
2 of 6 tasks
ghost opened this issue Feb 2, 2021 · 2 comments
Closed
2 of 6 tasks

Feature Request: Remove CDN #644

ghost opened this issue Feb 2, 2021 · 2 comments
Labels
size: medium status: done Work is completed and released (or scheduled to be released in the next version) type: bug report why: functionality Intended to improve ArchiveBox functionality or features

Comments

@ghost
Copy link

ghost commented Feb 2, 2021

Type

  • General question or discussion
  • Propose a brand new feature
  • Request modification of existing behavior or design

What is the problem that your feature request solves

The client requests javascript files from third party CDNs.

https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.6/js/bootstrap.min.js
https://code.jquery.com/jquery-3.2.1.slim.min.js

Describe the ideal specific solution you'd want, and whether it fits into any broader scope of changes

Remove CDNs and serve the remote files locally instead

Alternative: Config option to toggle the CDN

What hacks or alternative solutions have you tried to solve the problem?

Block CDN with browser addon

How badly do you want this new feature?

  • It's an urgent deal-breaker, I can't live without it
  • It's important to add it in the near-mid term future
  • It would be nice to have eventually
@ghost ghost added why: functionality Intended to improve ArchiveBox functionality or features status: idea-phase Work is tentatively approved and is being planned / laid out, but is not ready to be implemented yet labels Feb 2, 2021
@pirate
Copy link
Member

pirate commented Feb 2, 2021

Hmm how do these CDN assets keep getting added back, this is like the 3rd time I've removed them...

@pirate pirate added size: medium type: bug report and removed status: idea-phase Work is tentatively approved and is being planned / laid out, but is not ready to be implemented yet labels Feb 26, 2021
@pirate
Copy link
Member

pirate commented Apr 6, 2021

Fixed in af6561b. It will be released in the next version v0.6 soon.

@pirate pirate closed this as completed Apr 6, 2021
@pirate pirate added the status: done Work is completed and released (or scheduled to be released in the next version) label Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: medium status: done Work is completed and released (or scheduled to be released in the next version) type: bug report why: functionality Intended to improve ArchiveBox functionality or features
Projects
None yet
Development

No branches or pull requests

1 participant