Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR/Patches have no support for test environment #15

Closed
marked opened this issue Dec 10, 2018 · 4 comments
Closed

PR/Patches have no support for test environment #15

marked opened this issue Dec 10, 2018 · 4 comments
Labels
wontfix

Comments

@marked
Copy link
Contributor

marked commented Dec 10, 2018

PR's for patches should ideally be tested first but scripts do not support testing environment without modification by hand.
@kiska3
Copy link
Contributor

kiska3 commented Dec 10, 2018

You can modify: https://github.com/ArchiveTeam/tumblr-grab/blob/master/pipeline.py#L64

And test using server5.kiska.pw:9080 and import using admin url, then queue tasks as tumblr-blog:

Unfortunately I have gotten use to modifying that line enough that I don't mind.

@marked
Copy link
Contributor Author

marked commented Dec 10, 2018

I'm more concerned about those testing changes, besides us, need to be kept off the production tracker. I'll write up some options.

@marked marked mentioned this issue Dec 12, 2018
Closed
@km09
Copy link
Contributor

km09 commented Dec 13, 2018

https://git-scm.com/docs/git-branch

@km09 km09 closed this as completed Dec 13, 2018
@marked
Copy link
Contributor Author

marked commented Dec 14, 2018

Disagree. I've seen more than one person run tests again the production tracker. Not having a simple path to testing env leads to nobody testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@marked @km09 @kiska3 @Arkiver2