Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get-wget-lua should bail out earlier if dependencies aren't available #4

Open
ghost opened this issue Dec 9, 2018 · 5 comments
Open

Comments

@ghost
Copy link

ghost commented Dec 9, 2018

Script bailed out at the last minute because pkg-config wasn't found (then the correct ssl wasn't found) - which is a silent failure earlier in the script.

If you detect dependencies earlier this could bail out earlier and save time and downloads.

@nepeat
Copy link

nepeat commented Dec 10, 2018

I've setup a few instances and I've lost a few crawls because of the ARM Warrior not having rsync inside the Dockerfile. I'm going to submit a PR for the Warrior but I agree that this pipeline should check for dependencies so that future crawls don't break.

@raspher
Copy link

raspher commented Dec 14, 2018

missing dependencies list

im getting few compile errors, and lost more than half hour for compiling ...

@deutrino
Copy link

Yes, this is painful on ARM hardware.

@marked
Copy link
Contributor

marked commented Dec 23, 2018

If you want to have deps checked manually, I'd prefer a separate script as it's very distro dependent how you do that.

I agree that that there shouldn't be a compile if it's know it's going to fail, but demonstrated that that can be predicted reliably.

@marked
Copy link
Contributor

marked commented Dec 24, 2018

This is a candidate for the next build script. Could someone test it on ARM.
https://gist.github.com/marked/c683f07048174bed2812a6cc6eac029e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants