Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of organization types (remove LegalStatus from the conversion) #16

Closed
tfrancart opened this issue Dec 6, 2022 · 3 comments
Labels
EAC to RiC-O Specifically for the EAC conversion enhancement New feature or request status:blocked Blocked by other issue or question

Comments

@tfrancart
Copy link
Collaborator

EAC to RiC-O : Prendre en compte la nouvelle version du vocabulaire des types d’organismes (supprimer le vocabulaire LegalStatus de la conversion)

@tfrancart tfrancart added enhancement New feature or request EAC to RiC-O Specifically for the EAC conversion labels Dec 6, 2022
@tfrancart
Copy link
Collaborator Author

@florenceclavaud I started to address that in this commit : 8577d0e

But I think this is not sufficient, as the LegalStatus needs to be removed from the conversion. Does it mean the unit tests need to be changed ? if yes please update unit tests 23, 25B and 25F on branch "issue-16-legalStatus".

Let's discuss this.

@tfrancart tfrancart added the status:blocked Blocked by other issue or question label Feb 21, 2023
@florenceclavaud
Copy link
Contributor

Yes the unit tests have to be updated. The URI of the target CorporateBodyType should now be as follows:
corporateBodyType/FRAN_RI_104-{string}
the string being the value of legalStatus/term/@vocabularySource in the source file.

@tfrancart
Copy link
Collaborator Author

Similaire à OccupationType:

<xsl:function name="eac2rico:URI-OccupationType">
		<xsl:param name="vocabularySource" />
		<xsl:value-of select="concat('occupationType/', 'FRAN_RI_010-', $vocabularySource)" />
	</xsl:function>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EAC to RiC-O Specifically for the EAC conversion enhancement New feature or request status:blocked Blocked by other issue or question
Projects
None yet
Development

No branches or pull requests

2 participants