Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differenciate between Person and Organization when relating an agent to an activity #17

Closed
tfrancart opened this issue Dec 6, 2022 · 5 comments
Assignees
Labels
EAC to RiC-O Specifically for the EAC conversion enhancement New feature or request status:to be reviewed

Comments

@tfrancart
Copy link
Collaborator

différencier pour les relations entre l’agent et une activité, le cas des personnes et le cas des
organismes

@tfrancart tfrancart added enhancement New feature or request EAC to RiC-O Specifically for the EAC conversion labels Dec 6, 2022
@tfrancart
Copy link
Collaborator Author

@florenceclavaud can you please update the unit tests for this as I don't clearly see what needs to be changed ? Thanks

@tfrancart tfrancart added the status:blocked Blocked by other issue or question label Feb 21, 2023
@tfrancart
Copy link
Collaborator Author

Note : you can add these on newly created branch issue-17-relationAgentActivity

@florenceclavaud
Copy link
Contributor

I have begun to work on this, and so I have modified the expected.xml file for the _22occupation test. Both unit tests (about occupations and functions) still have to be modified, in order to add the rico:performsOrPerformed shortcuts: just like for the Mandate case mentioned in a comment on issue #5, the target activities will always be blank nodes. So we need to generate a rdf:nodeID for these activities, and to reuse them for the shortcut.

@tfrancart tfrancart removed the status:blocked Blocked by other issue or question label Mar 15, 2023
@tfrancart tfrancart self-assigned this Mar 15, 2023
@tfrancart
Copy link
Collaborator Author

Unit test OK, to be finalised and create PR

@tfrancart
Copy link
Collaborator Author

This is done and can be reviewed in #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EAC to RiC-O Specifically for the EAC conversion enhancement New feature or request status:to be reviewed
Projects
None yet
Development

No branches or pull requests

2 participants