Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Remove CsQuery (and replace Json.Net) #77

Open
1 of 2 tasks
ArcticEcho opened this issue May 18, 2015 · 2 comments
Open
1 of 2 tasks

Remove CsQuery (and replace Json.Net) #77

ArcticEcho opened this issue May 18, 2015 · 2 comments
Assignees
@ArcticEcho
Labels
Feature Request Med Priority Yam
Milestone
Phamhilator Netwo...

Comments

@ArcticEcho
Copy link
Owner

... for performance reasons.

  • Replace Newtonsoft.Json with ServiceStack.Text.
  • Replace CsQuery with regex.
@ArcticEcho ArcticEcho self-assigned this May 18, 2015
@ArcticEcho ArcticEcho added this to the Phamhilator Network v2 milestone May 18, 2015
@ArcticEcho ArcticEcho mentioned this issue May 18, 2015
Open
14 tasks
@thomas-daniels
Copy link
Collaborator

What are you going to use instead?

@ArcticEcho
Copy link
Owner Author

Well, after thoroughly reviewing all CsQuery usages (and the profiler reports), it would seem that using Regex would be a suitable replacement (it'll require a bit of work, but the performance gain will be worth it).

And as for Newtonsoft.Json, I'll be switching to ServiceStack.Text.

@ArcticEcho ArcticEcho changed the title Remove CsQuery Remove CsQuery (and replace Json.Net) May 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ArcticEcho ArcticEcho

Labels
Feature Request Med Priority Yam
Projects
None yet
Milestone
Phamhilator Network v2
Development

No branches or pull requests
2 participants
@ArcticEcho @thomas-daniels