Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GreeterList: Fix check for LightDM.PromptType.SECRET, let screen read… #74

Conversation

sunweaver
Copy link
Member

@sunweaver sunweaver commented Sep 21, 2023

…er read "Enter username" instead of "Enter password for <user>".

Fixes: #72

…er read "Enter username" instead of "Enter password for <user>".

Fixes: ArcticaProject#72
@Ionic
Copy link
Member

Ionic commented Sep 25, 2023

I'll work on this next week, but a cursory glance tells me that something must be missing in this PR. The only change in here doesn't make sense - the code should be functionally equivalent. Especially so, since vala doesn't have a feature that would convert other types implicitly to boolean, so if the code was accepted before, checking against true should change exactly nothing.

@sunweaver
Copy link
Member Author

Yeah, you are right, this one smells fishy. Not sure what drove me. Indeed, with the above changed, orca started reading the correct phrase. However, it now also reads the correct phrase without this change.

Closing for now... Need to revisit this.

@sunweaver sunweaver closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a11y: username field let's screen reader ask for "Enter password for <username>"
2 participants