Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved tsconfig: Target the actual feature set of Node >=12 #173

Merged
merged 5 commits into from
Jun 22, 2021
Merged

Improved tsconfig: Target the actual feature set of Node >=12 #173

merged 5 commits into from
Jun 22, 2021

Conversation

voxpelli
Copy link
Contributor

es6 also goes by the name of es2015 and eg. async/await didn't arrive until es2017 while Node 12 actually supports even es2019 fully.

Rather than keeping track of all of that in here, and ensuring to stay up to date here when new LTS versions gets released, I included a shared recommended minimal tsconfig as a base tsconfig for eg. that data.

On top of that I also added declarationMap to get source maps which maps from .d.ts to the original .ts files. This helps in debugging things and looking things up in eg. VSCode.

Sorry for not updating the lock file, my local yarn was acting up (I've moved to npm again myself since a few months so my new computer haven't really had yarn on it)

Also sorry for not using proper styling of the commit messages, maybe you can do a squash merge and/or cherry pick and set the correct commit messages then?

tsconfig.json Outdated Show resolved Hide resolved
@AriPerkkio
Copy link
Owner

Thanks for the help @voxpelli. The tsconfig/bases looks really handy - I'm glad you brought that up. I'll definitely start to use those in my other projects as well.

I'll need to do some studying about the changes before merging. The CI is now happy so everything should be working fine. 👍

@AriPerkkio AriPerkkio merged commit 65ec3d8 into AriPerkkio:master Jun 22, 2021
@voxpelli voxpelli deleted the improved-tsconfig branch June 22, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants