Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use react@17 #359

Merged
merged 2 commits into from
Apr 20, 2022
Merged

fix: use react@17 #359

merged 2 commits into from
Apr 20, 2022

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Apr 20, 2022

@AriPerkkio
Copy link
Owner

Pending for the ink's version bumps. The react versions must match 100%, ref. #302.

@SimenB
Copy link
Contributor Author

SimenB commented Apr 20, 2022

Ink is wrong 🤷 and specifying 17.0.2 is within Ink's peer range

@AriPerkkio
Copy link
Owner

specifying 17.0.2 is within Ink's peer range

Ah, that's right. This should be fine then.

I'll do some testing before merging this just to be sure.

@AriPerkkio
Copy link
Owner

Current version requirement is indeed incorrect. While npm is able to resolve correct version, yarn ends up with incorrect one.

$ yarn
yarn install v1.22.5
...
warning "eslint-remote-tester > ink > react-reconciler@0.26.2" has incorrect peer dependency "react@^17.0.2".

$ yarn why react
yarn why v1.22.5
...
=> Found "react@18.0.0"
info Reasons this module exists
   - "eslint-remote-tester" depends on it
   - Hoisted from "eslint-remote-tester#react"
$ npm why react

react@17.0.2
node_modules/react
  react@">=16.8.0" from eslint-remote-tester@2.1.3
  node_modules/eslint-remote-tester
    eslint-remote-tester@"^2.1.3" from the root project
  peer react@">=16.8.0" from ink@3.2.0
  node_modules/ink
    ink@"^3.2.0" from eslint-remote-tester@2.1.3
    node_modules/eslint-remote-tester
      eslint-remote-tester@"^2.1.3" from the root project
  peer react@"^17.0.2" from react-reconciler@0.26.2
  node_modules/react-reconciler
    react-reconciler@"^0.26.2" from ink@3.2.0
    node_modules/ink
      ink@"^3.2.0" from eslint-remote-tester@2.1.3
      node_modules/eslint-remote-tester
        eslint-remote-tester@"^2.1.3" from the root project

@AriPerkkio AriPerkkio merged commit d937271 into AriPerkkio:master Apr 20, 2022
@AriPerkkio
Copy link
Owner

Thanks!

@SimenB SimenB deleted the patch-1 branch April 20, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants