Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State of the Tests #194

Closed
whazzmaster opened this issue Sep 20, 2018 · 2 comments · Fixed by #196
Closed

State of the Tests #194

whazzmaster opened this issue Sep 20, 2018 · 2 comments · Fixed by #196

Comments

@whazzmaster
Copy link

I'm just checking in to see what the state of the tests should be at the tip of master. I forked the repo, successfully (I think!) setup everything and when I run bundle exec rake spec I get the following results:

failures

Is this expected? I noticed when the #165 merged it had CI failures so I wasn't positive that I setup things wrong.

If these failures are known and expected as of right now, I'm happy to invest some time fixing them, but I didn't want to go down that road if they're unexpected and I just missed a setup step.
@Ariel-Thomas
Copy link
Owner

Yeah, I was really uncertain about what things should look like for season 8 and I was trying to get the work done quickly so a lot of my tests fell behind. Fixing them is fairly high up on my todo list.

@whazzmaster
Copy link
Author

Cool, I can jump on that.

@whazzmaster whazzmaster mentioned this issue Sep 20, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes specs whazzmaster/adventurers-league-log
2 participants
@whazzmaster @Ariel-Thomas