➕ Adding required dependency: php version #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Buen detalle |
MarioPerini
suggested changes
Mar 19, 2021
|
@MarioPerini If I'm not mistaken that would mean saying it's compatible with php 9 (which doesn't exist so we don't know). It's usually recommended to be explicit. |
ArielMejiaDev
requested changes
Jun 1, 2021
| @@ -9,7 +9,8 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "ext-json": "*" | |||
| "ext-json": "*", | |||
There was a problem hiding this comment.
Please add this change to make it useful for php 7 and 8:
"php": "^7.0|^8.0",
|
it has already been added in the new 2.0 version of the package it supports PHP 7.4 to PHP 8.0 at this moment, when new PHP version Thanks for this suggestion and the PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the php version required to the composer file. The code used doesn't work below php7.
More specifically scalar type hints. See here:
https://3v4l.org/Mp7GNj