Support Panasonic lens type in RW2 and JPG #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source for tag ids was http://www.exiv2.org/tags-panasonic.html.
It appeared all ASCII values in the panasonic maker notes appeared to be ''. Playing around with the offsets showed that this commit fixes this issue for all my test files.
MakerNoteProbe uses (current) metadata, which at this point only contains a preliminary placeholder. At the end of the EXIF processing, this is merged into IFD0, which makes the data available for MakerNoteProbe too. This commit introduces a EXIF IFD0 merge just before the maker note is getting probed.
This is not the most elegant way to do this, but by far the easiest. Better would be to lookup the IFD in the bytebuffer and put the ExifMetadataReader to work. It seems to me that this involves a lot of rework in the EXIF code, as it assumes all offsets to be absolute to the beginning of the file, which is not the case when processing embedded JPEGs.
|
Thank you for the great work! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LightZone does not handle Panasonic lens info stored in both RW2 and JPEGs very well. See #200. There are a couple of issues casuing this:
I have fixed all four issues in the PR, and it seems to load RW2's and JPEG's correclt, with lens info. Added bonus: the exported JPEG's contain a proper XMP header for my lens.