Just moved from 4.0.2 to 4.2.0 - Two very small questions

[rebop]

HI there Aris-t2. Just spent about 4 hours moving to latest version as I wil lbe updating FF ESR soon. All wnet well, though tedious, except for tow small issues I cannot find.

1. Cannot find where to change the color of the background of the tab bar, and
2. In previous version, when I hovered the location field or search field a border would appear to highlight it. It does not in the new version and cannot find where that setting might be.

Would appreciate the pointers.

Thanks so much.

[rebop]

I found one more I cannot find, the spacing of items in menus, particulalry the bookmarks menu, is to much compared to the last version (4.0.2) I was using. I am sure that was a result of a tweak I cannot find. Images below of 4.0.2 vs 4.2.0:

Thanks again.

[rebop]

@Aris-t2 should I have posted this in a different place? I see things have changed here a bit. Sorry if so. Would hope these are easy and quick tweaks. All worked in a previous version, I just cannot find out where I tweked them after searching every css file in use.

Thanks.

~Bob

[rebop]

Tried to find way to move this to General Questions and could not.

[Aris-t2]

Cannot find where to change the color of the background of the tab bar, and

There is no "option" for that in general, it only is available for "tabs below navigation bar" mode in color_variables.css.

This will work:

#TabsToolbar:not(:-moz-lwtheme){
  background-color: blue !important;
}

In previous version, when I hovered the location field or search field a border would appear to highlight it. It does not in the new version and cannot find where that setting might be.

This was a default browser feature.

The code below will work:

#urlbar:not([focused="true"]):hover #urlbar-background,
#searchbar:not(:focus-within):hover {
  border: 1px solid Highlight !important;
}

I found one more I cannot find, the spacing of items in menus, particularly the bookmarks menu, is to much compared to the last version (4.0.2) I was using. I am sure that was a result of a tweak I cannot find. Images below of 4.0.2 vs 4.2.0:

You have to enable popup_compact_menus.css. Inside that file you can change spacing be modifying the value of --item_y_padding variable.

[rebop]

Thanks.
Background color of the tab bar DEFINITELY adjusted from default in 4.0.2. Just cannot find it!

Will try all of this and back later today when I know the results.

Thanks! As always....

[rebop]

OK first good news:

I tweaked the highlight and added to my_userChrome.css and this works like a charm:
#urlbar:not([focused="true"]):hover #urlbar-background,
#searchbar:not(:focus-within):hover {
border: .5px solid grey !important;
}

BUT:
#TabsToolbar:not(:-moz-lwtheme){
background-color: blue !important;
}
in my_UserChrome did nothing.

I believe the code in 4.0.2 that made the change for me was in custom_tab_color_settings and was:
--default_tabs_toolbar_background: #F0F0F0

That does not work in 4.2.0

And last, I had this in my_userChrome 4.0.2 which DID work but not now:

:root{
--item_y_padding: 10px; /* old value: 2px /
--y_padding_before_label: 28px !important; / for popup_menus_space_before_label.css /
--y_padding_before_label_bm: calc(var(--y_padding_before_label) - 2px ) !important; / for popup_menus_space_before_label.css */
--panel-padding: 0px !important;
--arrowpanel-menuitem-margin: 0px !important;
--arrowpanel-menuitem-padding: calc( var(--item_y_padding) + 1px) 2px !important;
--panel-subview-body-padding: 0px !important;
}

No matter WHAT I try in popup_compact_menus.css which IS enabled has no effect.

Can we look at those two a little more?

Thanks again.

[2BeeOrNot]

Try

#TabsToolbar:not(:-moz-lwtheme){
/* background, not background-color */
background: blue !important;
}

[rebop]

Thanks, but no change.

Do i need to mention that I have my tabs at the bottom of the window? Does that make a difference?

[Aris-t2]

It does. Use the variable to change the color: https://github.com/Aris-t2/CustomCSSforFx/blob/master/classic/config/color_variables.css#L19

[rebop]

Thanks, but tried everything I could find or think of to change in color_variables.css and no changes at all to background color. Tried changing the gradient to a color, etc. Perhaps you could be more specific?

And same with any Y padding which had no effect. And as posted, the lines I had in my_userChrome for 4.0.2 do not qwork in 4.2.0. Any idea what can be changed there to make the padding work?

Thanks....

[rebop]

OK, just tried Chrome from 4.2.0 in Firefox 91 where I am using 4.0.2. The tab bar background does not change, but the padding in menus does using the lines from my_UserChrome. So it works in older Firefox, but not 103. Hopefully that helps with the padding.

Same with the custom_tab_color_settings --default_tabs_toolbar_background: #F0F0F0;

Works in FF 91. Not in FF 103.

[rebop]

Ooops, last part of that not true. The custom_tab_color_settings modified as above and put in FF 91 does not work. Sorry.

[Aris-t2]

userChrome.css > enabled @import "./css/tabs/tabs_below_navigation_toolbar.css
color_variables.css > changed --tabs_toolbar_color_tabs_not_on_top: linear-gradient(red,blue) !important;

result

userChrome.css > enabled @import "./css/tabs/tabs_below_main_content.css
color_variables.css > changed --tabs_toolbar_color_tabs_not_on_top: linear-gradient(red,blue) !important;

result

[rebop]

Thanks so much, but does not work for me. No idea why not:   Something must be overriding this? To be honest. This is just a nice to have. Would love the change, but more important tightening up the menus. Thanks again Aris-T2 (Sorry - replying to the email did not work as expected)

[Aris-t2]

Make a clean setup of this projects files only. Edit files like shown above.

[rebop]

Sorry to reply so late, but small medical foo got in the way.

Just did exactly this and no change in the color. Truly Has me totally baffled. Almost like something still in memory.

But as mentioned, this is just a "nice to have" Will miss it, but more iomportant to tighten up menus. Can we try to sleuth thayt one further?

Aside from these two things, everything is just exactly as I desire.

[rebop]

OK, just tried an experient.

Downloaded a fresh FF ESR 102.1 portable, setup VIRGIN. Added the test Chrome with ONLY your suggested changes.

Tab bar did not move to the bottom and color did not change.

Has to be some sort of clue. no?

[rebop]

My bad. Forgot to change toolkit.legacyUserProfileCustomizations.stylesheets to true and after that, it does work in a virgin FF install. So now to try to figure out why it does not work in my profile.

[rebop]

Its a theme conflict. with default theme, it works. SO now I can eiother live with the change (likely) or try to find another theme to muy liking where it does work. Whew. At least understood now.

So if you would not mind pointing me where to poke to change menu spacings. I will try changes in the virgin install to see if my old changes worked there while I poke around some more.

[Aris-t2]

Most color changes are for default theme only. That is made sure by using :not(:-moz-lwtheme) rule.

Instead of this, you need the opposite rule:

#TabsToolbar:-moz-lwtheme {
  background-color: blue !important;
}

or

#TabsToolbar:-moz-lwtheme {
  background-image: linear-gradient(red,blue) !important;
}

[rebop]

OK, got the menu paddings. Conflict in my_UserChrome and the .css for popup. Works as expected now. Sorry these were all me. Took a bit to sort them all out.

~Bob

[rebop]

OK, all is good again. Until the next FF ESR major changes at least.
Would like to send a latte. Paypal link just did not look right from GitHub. Can I have your PayPal name Aris-T2?

Thanks for all the help.

[Aris-t2]

It is the correct Paypal name you see following the link. "Aris" is just an old nickname ;-)
You can also send to my mail aris-addons [at] gmx [dot] net

Thanks.

[rebop]

Here's an odd one from FF 103 (which has MAJOR problems in my opinion).

Pretty ugly. Is there a fix to remove the highlighting box? No rush. Will be some time until I actually can use 103.

[Aris-t2]

Sorry for the late reply.

I don't know the correct id for downloads dialog atm, but this will solve the issue (tested on Fx 119 Nightly):

dialog *:focus {
  -moz-user-focus: none !important;
}