Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mosaic + windowing wrong output #492

Closed
RSDuck opened this issue Jul 21, 2019 · 1 comment
Closed

Mosaic + windowing wrong output #492

RSDuck opened this issue Jul 21, 2019 · 1 comment

Comments

@RSDuck
Copy link
Collaborator

@RSDuck RSDuck commented Jul 21, 2019

This is a tiny edge case, so not so much of importance. In GPU2D.cpp in multiple occasions (like here: https://github.com/Arisotura/melonDS/blob/master/src/GPU2D.cpp#L1661) the mosaic counter is only updated while inside an area which isn't blocked by the window.

The effect of this can be tested with this: https://gist.github.com/RSDuck/e8064791e80f27bd797001af7f4e2084

melonDS:
grafik

hardware:
grafik

@Arisotura
Copy link
Owner

@Arisotura Arisotura commented Jul 24, 2019

relatedly: mosaic will not work on large BG due to a stupid-ass oversight.

mosaic needs a overhaul anyway.

@RSDuck RSDuck closed this Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants