feat: Instrumentation reads session id from metadata #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
…ion-langchain * main: fix: update pdfjs-dist in llama-index-express example (#445)
axiomofjoy
reviewed
May 10, 2024
...eninference-instrumentation-langchain/src/openinference/instrumentation/langchain/_tracer.py
Outdated
Show resolved
Hide resolved
axiomofjoy
reviewed
May 10, 2024
...instrumentation-langchain/tests/openinference/instrumentation/langchain/test_instrumentor.py
Outdated
Show resolved
Hide resolved
axiomofjoy
approved these changes
May 10, 2024
…/src/openinference/instrumentation/langchain/_tracer.py Co-authored-by: Xander Song <axiomofjoy@gmail.com>
…ion-langchain * main: chore(main): release python-openinference-instrumentation-bedrock 0.1.4 (#293) chore(main): release python-openinference-instrumentation-openai 0.1.5 (#294) chore(main): release python-openinference-instrumentation-mistralai 0.0.6 (#335) chore(main): release python-openinference-instrumentation-dspy 0.1.8 (#430)
dosubot
bot
added
size:XL
fjcasti1
deleted the
kiko/prompt-template-attributes-instrumentation-langchain
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so we capture the OpenInference span attribute
session.idfrom the lanchain metadata ifsession_id,conversation_id, orthread_idis present in it. If multiple are present, the order of preference isIn addition, we correct the order of preference of context attributes. This is, if we use our context managers to pass metadata, but a different metadata object is passed directly in the call, the latter will be selected over the former.
fix: Overwrite context attributes if passed directly to langchain calls