Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(persistence): make launch_app runnable on tmp directory #2851

Merged
merged 7 commits into from
Apr 19, 2024

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Apr 10, 2024

resolves #2843

Screenshot 2024-04-19 at 11 52 35 AM Screenshot 2024-04-19 at 11 52 51 AM

By default phoenix uses a temp directory and can be overridden via a flag to launch_app

@mikeldking mikeldking marked this pull request as ready for review April 19, 2024 17:58
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 19, 2024
src/phoenix/session/client.py Outdated Show resolved Hide resolved
src/phoenix/server/main.py Outdated Show resolved Hide resolved
src/phoenix/services.py Outdated Show resolved Hide resolved
@mikeldking mikeldking merged commit f41e922 into sql Apr 19, 2024
11 checks passed
@mikeldking mikeldking deleted the 2843-tmp-launch branch April 19, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants