fix: improve error handling and logging for eval insertions #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
Closed
axiomofjoy
added
size:XS
axiomofjoy
changed the title
dosubot
bot
added
size:M
axiomofjoy
commented
Apr 11, 2024
| except Exception: | ||
| logger.exception( | ||
| "Failed to insert evaluation " | ||
| f"for span_id={evaluation.SubjectId.span_id}" |
There was a problem hiding this comment.
This was causing #2841. Nested sessions are working otherwise.
RogerHYang
approved these changes
Apr 11, 2024
Comment on lines
+116
to
+117
| except InsertEvaluationError as error: | ||
| logger.exception(f"Failed to insert evaluation: {str(error)}") |
There was a problem hiding this comment.
i think this printing is automatic, so it would be a duplication
Suggested change
| except InsertEvaluationError as error: | |
| logger.exception(f"Failed to insert evaluation: {str(error)}") | |
| except InsertEvaluationError: | |
| logger.exception(f"Failed to insert evaluation") |
There was a problem hiding this comment.
The more granular error message is included in the stacktrace but not the log messages. I think it's worth keeping.
Co-authored-by: Roger Yang <80478925+RogerHYang@users.noreply.github.com>
Co-authored-by: Roger Yang <80478925+RogerHYang@users.noreply.github.com>
Co-authored-by: Roger Yang <80478925+RogerHYang@users.noreply.github.com>
This was referenced Apr 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes an error in a logging statement causing #2841 and improves error handling and logging.
resolves #2778