Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert graphql api to pull trace evaluations from db #2867

Merged
merged 3 commits into from
Apr 14, 2024

Conversation

axiomofjoy
Copy link
Contributor

makes graphql api pull trace evaluations from db

resolves #2777

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@axiomofjoy axiomofjoy changed the base branch from main to sql April 11, 2024 23:45
@axiomofjoy axiomofjoy marked this pull request as ready for review April 12, 2024 00:14
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 12, 2024
src/phoenix/server/api/types/Trace.py Outdated Show resolved Hide resolved
@axiomofjoy axiomofjoy linked an issue Apr 12, 2024 that may be closed by this pull request
@axiomofjoy axiomofjoy merged commit 11aa455 into sql Apr 14, 2024
12 checks passed
@axiomofjoy axiomofjoy deleted the graphql-trace-evaluations branch April 14, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

remove join in traces and spans resolvers on Project type [gql] evals API changes to read from tables
2 participants