Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: document evaluation aggregation #2888

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Conversation

axiomofjoy
Copy link
Contributor

resolves #2879

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@axiomofjoy axiomofjoy changed the base branch from main to sql April 13, 2024 01:29
@axiomofjoy axiomofjoy marked this pull request as ready for review April 13, 2024 01:33
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 13, 2024
models.Span.start_time < time_range.end,
)
)
# todo: add filter_condition
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add filter condition to document evaluation summary

@axiomofjoy axiomofjoy merged commit 73ca2d7 into sql Apr 13, 2024
5 checks passed
@axiomofjoy axiomofjoy deleted the document-eval-aggregation branch April 13, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[persistence] Document eval aggregation metric
2 participants