Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(persistence): db race condition between spans and evals #2905

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

RogerHYang
Copy link
Contributor

@RogerHYang RogerHYang commented Apr 16, 2024

Because the buffers are grabbed at different times, a span can miss the span buffer and stays in the queue, while its eval can be include the eval buffer, leading to eval insertion failure because eval can't insert if the span it references doesn't exist in the db.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 16, 2024
@axiomofjoy
Copy link
Contributor

Good catch and good mitigation. Let's still convert to a single queue in a follow-up.

@RogerHYang RogerHYang merged commit 2666464 into sql Apr 16, 2024
13 checks passed
@RogerHYang RogerHYang deleted the fix-db-race-condition branch April 16, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants