Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Propagate migration errors and show an informative message #2994

Merged
merged 6 commits into from
Apr 26, 2024
Merged

fix: Propagate migration errors and show an informative message #2994

merged 6 commits into from
Apr 26, 2024

Conversation

anticorrelator
Copy link
Contributor

resolves #2921

  • Propagates errors outside of the worker thread if a migration error occurs
  • Shows a message that provides guidance on how to resolve migration issues

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Apr 26, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@anticorrelator anticorrelator changed the base branch from main to sql April 26, 2024 00:12
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Apr 26, 2024
@anticorrelator anticorrelator merged commit 3718e10 into sql Apr 26, 2024
11 checks passed
@anticorrelator anticorrelator deleted the dustin/break-on-migration-errors branch April 26, 2024 14:29
@github-actions github-actions bot mentioned this pull request May 9, 2024
Closed
@mikeldking mikeldking mentioned this pull request May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogerHYang RogerHYang RogerHYang approved these changes

Assignees
No one assigned
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: migration failures don't block the startup of the application
2 participants
@anticorrelator @RogerHYang