feat: add default limit to /v1/spans and corresponding client methods
#3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
dosubot
bot
added
the
size:M
RogerHYang
approved these changes
Apr 29, 2024
mikeldking
approved these changes
Apr 29, 2024
axiomofjoy
commented
Apr 29, 2024
Comment on lines
+53
to
-54
| default: default | ||
| description: The project name to add the evaluation to | ||
| default: default |
There was a problem hiding this comment.
Fix to OpenAPI schema.
Comment on lines
+114
to
-115
| default: default | ||
| description: The project name to get evaluations from | ||
| default: default |
There was a problem hiding this comment.
Fix to OpenAPI schema
Comment on lines
+26
to
-25
| default: default | ||
| description: The project name to get evaluations from | ||
| default: default |
There was a problem hiding this comment.
Fix to OpenAPI schema
Comment on lines
-107
to
-111
| """ | ||
| summary: Deprecated route for querying for spans, use the POST method instead | ||
| operationId: legacyQuerySpans | ||
| deprecated: true | ||
| """ |
There was a problem hiding this comment.
Remove this route from the OpenAPI schema since it is being deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/v1/spansphoenix.Clientandphoenix.Sessionmethodsresolves #3017