Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prometheus for bulkloader #3066

Merged
merged 7 commits into from
May 3, 2024
Merged

Conversation

RogerHYang
Copy link
Contributor

@RogerHYang RogerHYang commented May 3, 2024

Timers should be at the transactions (with disk write) and not at the statements (no disk write).

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 3, 2024
@RogerHYang RogerHYang changed the base branch from remove-grpc-interceptor to sql May 3, 2024 15:01
@RogerHYang RogerHYang merged commit e0cc58d into sql May 3, 2024
11 checks passed
@RogerHYang RogerHYang deleted the fix-prometheus-for-bulkloader branch May 3, 2024 15:30
@axiomofjoy
Copy link
Contributor

nice, might make sense to create a context manager or decorator for prometheus down the road

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants