Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: round down time points to facilitate caching #3079

Merged
merged 1 commit into from
May 3, 2024
Merged

fix: round down time points to facilitate caching #3079

merged 1 commit into from
May 3, 2024

Conversation

RogerHYang
Copy link
Contributor

No description provided.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 3, 2024
axiomofjoy
axiomofjoy reviewed May 3, 2024
View reviewed changes
Copy link
Contributor

@axiomofjoy axiomofjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This strikes me as something that should be handled on the backend so that other eventual consumers of our GraphQL APIs (in addition to the frontend) can benefit from caching?

@RogerHYang RogerHYang merged commit 42b03c9 into sql May 3, 2024
6 checks passed
@RogerHYang RogerHYang deleted the round-time-for-cache branch May 3, 2024 20:27
@RogerHYang RogerHYang mentioned this pull request May 6, 2024
Merged
@github-actions github-actions bot mentioned this pull request May 9, 2024
Closed
@mikeldking mikeldking mentioned this pull request May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeldking mikeldking mikeldking approved these changes

@axiomofjoy axiomofjoy axiomofjoy approved these changes

Assignees
No one assigned
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RogerHYang @mikeldking @axiomofjoy