Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve rounding issue in postgres #3232

Merged
merged 2 commits into from
May 17, 2024

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented May 17, 2024

This issue affects Postgres 12, since the result of EXTRACT changed from double precision to numeric in postgres 14. https://stackoverflow.com/questions/72375207/extract-returns-numeric-instead-double-precision/72375709#72375709

Copy link
Contributor

@RogerHYang RogerHYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamped to unblock

@axiomofjoy axiomofjoy marked this pull request as ready for review May 17, 2024 23:01
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 17, 2024
@axiomofjoy axiomofjoy merged commit 3b6c666 into main May 17, 2024
12 checks passed
@axiomofjoy axiomofjoy deleted the resolve-rounding-issue-in-postgres branch May 17, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants