Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datasets][REST] /v1/datasets/<dataset_id>/upload should return 409 on conflict #3605

Closed
Tracked by #2017
axiomofjoy opened this issue Jun 21, 2024 · 1 comment · Fixed by #3607
Closed
Tracked by #2017

[datasets][REST] /v1/datasets/<dataset_id>/upload should return 409 on conflict #3605

axiomofjoy opened this issue Jun 21, 2024 · 1 comment · Fixed by #3607
Labels
c/server Server implementation

Comments

@axiomofjoy
Copy link
Contributor

axiomofjoy commented Jun 21, 2024 •
edited
Loading

We currently return a 422 Unprocessable Entity with no further error message when uploading a dataset with an already existing name. We should return a 409 conflict and a more descriptive error message.
@axiomofjoy axiomofjoy mentioned this issue Jun 21, 2024
Closed
@dosubot dosubot bot added the c/server Server implementation label Jun 21, 2024
@axiomofjoy axiomofjoy changed the title /v1/datasets/<dataset_id>/upload should return 409 on conflict [datasets][REST] /v1/datasets/<dataset_id>/upload should return 409 on conflict Jun 21, 2024
@axiomofjoy axiomofjoy mentioned this issue Jun 21, 2024
Merged
@axiomofjoy
Copy link
Contributor Author

This one is not yet resolved.

@axiomofjoy axiomofjoy reopened this Jun 21, 2024
@axiomofjoy axiomofjoy mentioned this issue Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/server Server implementation
Projects
phoenix
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: rename upload_dataset_examples to upload_dataset and add return type Arize-ai/phoenix
2 participants
@axiomofjoy @RogerHYang