feat(radio): add typescript support for accepting react node #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
recheck |
size-limit report 📦
|
mikeldking
reviewed
Mar 27, 2024
| @@ -45,7 +45,7 @@ export type RadioProps = { | |||
| /** | |||
| * The actual text to be displayed `Cats For Adoptions` | |||
| */ | |||
| label: string; | |||
| label: string | ReactNode; | |||
There was a problem hiding this comment.
I'm okay with this but note that this has a bit of a11y implications. Can you double check that the text node of whatever react node you pass in get's read in for a11y?
There was a problem hiding this comment.
Verified with Chrome Lighthouse that there were no accessibility issues using a node. From the code, it looks like all aria values are appended using the value prop being passed in, so the label being a node should not affect (unless the node being passed in does not pass a11y)
|
@bbleungg spelling error in the title of the PR |
mikeldking
approved these changes
Mar 27, 2024
bbleungg
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds Typescript support for
Radiolabel accepting a React node