Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padding missing in Flex component #218

Open
Nabeegh-Ahmed opened this issue Jun 15, 2024 · 1 comment
Open

padding missing in Flex component #218

Nabeegh-Ahmed opened this issue Jun 15, 2024 · 1 comment

Comments

@Nabeegh-Ahmed
Copy link

It appears that padding field is missing from Flex. I explored the code and discovered that FlexStyleProps extends from StyleProps and padding is only available in ViewStyleProps.

Trying to understand why this decision was made. I can open a PR but what would be the better method of implementing this?

Thanks.

@mikeldking
Copy link
Collaborator

Thanks for the suggestion. We intended these components (view and flex)to have logical definitions and to be used in relation to each other. This does create div bloat. We would accept a contribution adding additional style props to Flex which would prevent the extra View components. The contribution would need to include tests, updated documentation, as well as Chromatic and Storybook additions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants