fix: secret validation

ArkEcosystemArchive · Jun 25, 2018 · 48ca2c9 · 48ca2c9
1 parent d92b91d
commit 48ca2c9
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/lib/transactions/delegate.js b/lib/transactions/delegate.js
@@ -12,7 +12,7 @@ var crypto = require("./crypto.js"),
  * @param {number} [feeOverride]
  */
 function createDelegate(secret, username, secondSecret, feeOverride) {
-	if (!secret || !username) return false;
+	if (typeof secret === 'undefined' || !username) return false;
 
 	var keys = secret;
 

diff --git a/lib/transactions/ipfs.js b/lib/transactions/ipfs.js
@@ -12,7 +12,7 @@ var crypto = require("./crypto.js"),
  * @param {number} [feeOverride]
  */
 function createHashRegistration(ipfshash, secret, secondSecret, feeOverride) {
-	if (!ipfshash || !secret) return false;
+	if (!ipfshash || typeof secret === 'undefined') return false;
 
 	if (feeOverride && !Number.isInteger(feeOverride)) {
 		throw new Error('Not a valid fee')

diff --git a/lib/transactions/multisignature.js b/lib/transactions/multisignature.js
@@ -33,7 +33,7 @@ function signTransaction(trs, secret) {
  * @param {number} [feeOverride]
  */
 function createMultisignature(secret, secondSecret, keysgroup, lifetime, min, feeOverride) {
-	if (!secret || !keysgroup || !lifetime || !min) return false;
+	if (typeof secret === 'undefined' || !keysgroup || !lifetime || !min) return false;
 
 	var keys = secret;
 

diff --git a/lib/transactions/signature.js b/lib/transactions/signature.js
@@ -26,7 +26,7 @@ function newSignature(secondSecret) {
  * @returns {Transaction}
  */
 function createSignature(secret, secondSecret, feeOverride) {
-	if (!secret || !secondSecret) return false;
+	if (typeof secret === 'undefined' || !secondSecret) return false;
 
 	var keys = secret;
 

diff --git a/lib/transactions/transaction.js b/lib/transactions/transaction.js
@@ -16,7 +16,7 @@ var crypto = require("./crypto.js"),
  * @returns {Transaction}
  */
 function createTransaction(recipientId, amount, vendorField, secret, secondSecret, version, feeOverride) {
-	if (!recipientId || !amount || !secret) return false;
+	if (!recipientId || !amount || typeof secret === 'undefined') return false;
 
   if(!crypto.validateAddress(recipientId, version)){
     throw new Error("Wrong recipientId");

diff --git a/lib/transactions/vote.js b/lib/transactions/vote.js
@@ -13,7 +13,7 @@ var crypto = require("./crypto.js"),
  * @returns {Transaction}
  */
 function createVote(secret, delegates, secondSecret, feeOverride) {
-	if (!secret || !Array.isArray(delegates)) return;
+	if (typeof secret === 'undefined' || !Array.isArray(delegates)) return;
 
 	var keys = secret;