Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable -Wall -Wextra -Wshadow -Wconversion -Wpedantic #460

Open
Tracked by #415
SuperFola opened this issue May 16, 2024 · 0 comments
Open
Tracked by #415

Enable -Wall -Wextra -Wshadow -Wconversion -Wpedantic #460

SuperFola opened this issue May 16, 2024 · 0 comments
Labels
👷 ci Related to our Continous Integration system (build, tests, auto-release...) enhancement New feature or request ❗️ priority/low

Comments

@SuperFola
Copy link
Member

SuperFola commented May 16, 2024

I tend to forget about Werror because of external libraries which aren't compliant. We used to have utf8_decoder (but now it's gone) that didn't comply ; IIRC replxx isn't either.

Some tests will have to be conducted through the CI with those flags directly enabled inside the CMakeLists (so that they are useful locally too).

@SuperFola SuperFola changed the title -Wall -Wextra -Wshadow -Wconversion -Wpedantic (forgetting about Werror here because of external libraries which aren't compliant, I'm looking at you utf8_decoder) Enable -Wall -Wextra -Wshadow -Wconversion -Wpedantic May 16, 2024
@SuperFola SuperFola added enhancement New feature or request ❗️ priority/low 👷 ci Related to our Continous Integration system (build, tests, auto-release...) labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👷 ci Related to our Continous Integration system (build, tests, auto-release...) enhancement New feature or request ❗️ priority/low
Projects
None yet
Development

No branches or pull requests

1 participant