Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error first callbacks #5

Closed
jdpnielsen opened this issue Jul 16, 2016 · 3 comments
Closed

Error first callbacks #5

jdpnielsen opened this issue Jul 16, 2016 · 3 comments

Comments

@jdpnielsen
Copy link
Collaborator

jdpnielsen commented Jul 16, 2016 •
edited
Loading

I just saw that your mentioned adding in error handling in the #4.

I am currently working a pull request adding error first callbacks. Do you have any preferences for the error returned?
@Armax
Copy link
Owner

Armax commented Jul 16, 2016

Mm no, maybe just the classic function(err,res)

@jdpnielsen
Copy link
Collaborator Author

Yeah, that's what i meant. Would you prefer instances of Error or plain objects with a message and such?

@Armax
Copy link
Owner

Armax commented Jul 16, 2016

Instances of Error should be fine

@jdpnielsen jdpnielsen mentioned this issue Jul 16, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Armax @jdpnielsen