New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty files are always shown as modified #283

Closed
ArneBachmann opened this Issue Oct 3, 2018 · 2 comments

Comments

@ArneBachmann
Owner

ArneBachmann commented Oct 3, 2018

No description provided.

@ArneBachmann

This comment has been minimized.

Owner

ArneBachmann commented Oct 3, 2018

Reason is that we switched from simple to strict mode, which results in empty hashes.
I thought hashes are computed first time anyway and then ignored in findChanges, but this is not the case and also would make no sense once files start getting modified. Therefore a detection as changed makes sense.
But even once commited anew, the hash is not computed, although in strict mode. There seems to be a bug in findChanges.

@ArneBachmann

This comment has been minimized.

Owner

ArneBachmann commented Oct 4, 2018

There was a bug not computing the hash when size is 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment