Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty files are always shown as modified #283

Closed
ArneBachmann opened this issue Oct 3, 2018 · 2 comments
Closed

Empty files are always shown as modified #283

ArneBachmann opened this issue Oct 3, 2018 · 2 comments
Assignees
@ArneBachmann
Labels
bug difficulty-3-low investigate prio-2-medium reliability
Milestone
1.7

Comments

@ArneBachmann
Copy link
Owner

No description provided.

@ArneBachmann
Copy link
Owner Author

ArneBachmann commented Oct 3, 2018 •
edited
Loading

Reason is that we switched from simple to strict mode, which results in empty hashes.
I thought hashes are computed first time anyway and then ignored in findChanges, but this is not the case and also would make no sense once files start getting modified. Therefore a detection as changed makes sense.
But even once commited anew, the hash is not computed, although in strict mode. There seems to be a bug in findChanges.

@ArneBachmann
Copy link
Owner Author

There was a bug not computing the hash when size is 0

@ArneBachmann ArneBachmann self-assigned this Oct 4, 2018
@ArneBachmann ArneBachmann added this to the 1.7 milestone Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArneBachmann ArneBachmann

Labels
bug difficulty-3-low investigate prio-2-medium reliability
Projects
None yet
Milestone
1.7
Development

No branches or pull requests
1 participant
@ArneBachmann